Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Revert "Bump core-js from 3.35.0 to 3.35.1 (#678)" #682

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Feb 2, 2024

This reverts commit 0ecbb05.

It broke our e2e tests (only after PR went in) in ways we don't currently understand

Changes proposed in this pull request:

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

This reverts commit 0ecbb05.

It broke our e2e tests (only after PR went in) in ways
we don't currently understand
@surchs surchs added the pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) label Feb 2, 2024
Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit 847f381
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/65bd6503546fc40008a54505
😎 Deploy Preview https://deploy-preview-682--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem self-requested a review February 5, 2024 04:58
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@surchs surchs merged commit 9f66d63 into main Feb 6, 2024
8 checks passed
@surchs surchs deleted the rollback_corejs_bump branch February 6, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants